[webkit-reviews] review granted: [Bug 52781] Inserting multiple whitespace using text composition (IME) should insert interleaved nbsp and whitespace. : [Attachment 79951] fixes the bug

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 52781: Inserting multiple whitespace using text composition (IME) should
insert interleaved nbsp and whitespace.
https://bugs.webkit.org/show_bug.cgi?id=52781

Attachment 79951: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=79951&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79951&action=review

> Source/WebCore/editing/htmlediting.cpp:359
> +    Vector<UChar> rebalanacedString;

s/rebalanacedString/rebalancedString

Also, why use a Vector<UChar> instead of  String like the old code did?

> Source/WebCore/editing/htmlediting.h:239
>  // Miscellaneous functions on String
> -    
> +inline bool isWhitespace(UChar c)
> +{
> +    return c == noBreakSpace || c == ' ' || c == '\n' || c == '\t';
> +}

Nit: technically, this is not a function on String, os the comment is not
correct.