[webkit-reviews] review denied: [Bug 52612] Apply feature flags to user-agent style sheets : [Attachment 79395] Patch 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 24 15:35:01 PST 2011


Eric Seidel <eric at webkit.org> has denied Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 52612: Apply feature flags to user-agent style sheets
https://bugs.webkit.org/show_bug.cgi?id=52612

Attachment 79395: Patch 4
https://bugs.webkit.org/attachment.cgi?id=79395&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79395&action=review

I'm not sure why we need to do this?  Aren't these -webkit- rules going to be
ignored if the features in question are not enabled anyway?

r- for lack of ChangeLog.

> Source/WebCore/bindings/scripts/preprocessor.pm:36
> +sub applyPreprocessor

Sad that this ended up as perl.  Why do we even need a pre-processor?  Can't we
use GCC's?


More information about the webkit-reviews mailing list