[webkit-reviews] review granted: [Bug 52339] Remove sizeInBytes from GraphicsContext3D's various implementations : [Attachment 79978] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zhenyao Mo <zmo at google.com>'s request
for review:
Bug 52339: Remove sizeInBytes from GraphicsContext3D's various implementations
https://bugs.webkit.org/show_bug.cgi?id=52339

Attachment 79978: Patch
https://bugs.webkit.org/attachment.cgi?id=79978&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=79978&action=review

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:506
> +    default:
> +	   return 0;

Normally we leave defaults out of our switch statements to allow the compiler
to check that we covered all the enum values. Then, outside the switch we put
something like this:

    ASSERT_NOT_REACHED();
    return 0;

Because it’s not correct for someone to pass in a value that is not one of the
enum constants.