[webkit-reviews] review denied: [Bug 51873] [Symbian] RVCT fails to compile [U|I]nt[8|16|32]Array.h : [Attachment 79967] patch7
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 24 14:27:31 PST 2011
Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied qi
<qi.2.zhang at nokia.com>'s request for review:
Bug 51873: [Symbian] RVCT fails to compile [U|I]nt[8|16|32]Array.h
https://bugs.webkit.org/show_bug.cgi?id=51873
Attachment 79967: patch7
https://bugs.webkit.org/attachment.cgi?id=79967&action=review
------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Almost there.
I think the ChangeLog should explain why the change is made and that we're not
special-casing for RVCT.
You can also replace the non-ascii quotation marks with ascii onces, although
the try-bots seems to be ok.
Is there any reason you changed the order of the two functions ?
More information about the webkit-reviews
mailing list