[webkit-reviews] review granted: [Bug 52926] Add segmentation test for range.expand : [Attachment 79976] layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 24 14:20:41 PST 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 52926: Add segmentation test for range.expand
https://bugs.webkit.org/show_bug.cgi?id=52926

Attachment 79976: layout test
https://bugs.webkit.org/attachment.cgi?id=79976&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79976&action=review

> LayoutTests/fast/text/international/cjk-segmentation.html:5
> +<title>Test for CJK segmentation.</title>

Nit: Don't put period in the title.

> LayoutTests/fast/text/international/cjk-segmentation.html:50
> +    if (pass == true) {
> +	   log("ALL PASS");
> +    }

Nit: no { } around a single line statement.


More information about the webkit-reviews mailing list