[webkit-reviews] review granted: [Bug 53016] [GTK] Crash in some pages containing flash : [Attachment 79930] Patch to fix the crash

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 53016: [GTK] Crash in some pages containing flash
https://bugs.webkit.org/show_bug.cgi?id=53016

Attachment 79930: Patch to fix the crash
https://bugs.webkit.org/attachment.cgi?id=79930&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79930&action=review

Seems very reasonable to me!

> Source/WebCore/plugins/gtk/PluginPackageGtk.cpp:113
> +		 "This probably reflects a bug in the flash plugin.\n"

Here it should probably either say "in a plugin" or "in the Adobe Flash plugin"


> Source/WebCore/plugins/gtk/PluginPackageGtk.cpp:157
> +    if (!g_strcmp0(baseName.get(), "libflashplayer.so")) {

g_str_equal here might be clearer, unless there's a possibility that basename
may be null.

> Source/WebCore/plugins/gtk/PluginPackageGtk.cpp:160
> +	   // custom error handler to show a warning when a X error
happenswithout aborting.

"happenswithout" -> happens without