[webkit-reviews] review denied: [Bug 52839] [Qt][Symbian] Fix --minimal build : [Attachment 79927] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 24 13:14:22 PST 2011
Eric Seidel <eric at webkit.org> has denied Yael <yael.aharon at nokia.com>'s request
for review:
Bug 52839: [Qt][Symbian] Fix --minimal build
https://bugs.webkit.org/show_bug.cgi?id=52839
Attachment 79927: Patch
https://bugs.webkit.org/attachment.cgi?id=79927&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
? You're grepping the passed build flags? This doesn't make sense.
If you pass FOO= before a command, it gets set in the environment. If you pass
FOO= after build-webkit, it's supposed to treat all arguments it doesnt'
understand as arguments to be passed to the underlying build system. I assume
that's what you're tryign to do here? But if so, why special case
USE_SYSTEM_MALLOC. Are we sure thsi is the right fix?
More information about the webkit-reviews
mailing list