[webkit-reviews] review requested: [Bug 13834] Checkboxes and radio buttons don't see CSS background color : [Attachment 79961] Patch for Qtwebkit

[bugzilla-daemon at webkit.org]

aravind.akella at nokia.com has asked  for review:
Bug 13834: Checkboxes and radio buttons don't see CSS background color
https://bugs.webkit.org/show_bug.cgi?id=13834

Attachment 79961: Patch for Qtwebkit
https://bugs.webkit.org/attachment.cgi?id=79961&action=review

------- Additional Comments from aravind.akella at nokia.com
This is a qt specific fix for enabling background color to checkboxes & radio
buttons.
Setting the palette on the QStyleoption which is passed on to
QStyle::drawControl()	     
Currently background color is supported in windows,plastique styles. Other
styles like 
gtk,qts60,motif etc. don't support this. Running QtTestBrowser with -style 
windows/plastique option shows the background color for the checkbox.

W3C specification states background-color sets the background color of an
element, and 
this property applies to all elements.
(see http://www.w3.org/TR/CSS21/colors.html#propdef-background-color)

Opera and IE are currently the only browsers that attempt to support this
property for 
checkboxes and radio buttons.  Opera fills the checkbox rectangle with the
color specified 
in background-color property, whereas IE creates a colored border around the
checkbox 
rectangle using the background-color. With this fix QtWebkit based browsers
(with 
windows/plastique styles) will behave like opera.