[webkit-reviews] review canceled: [Bug 52581] preventDefault() in beforeload should prevent request : [Attachment 79893] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 23 22:21:56 PST 2011


Gavin Peters <gavinp at chromium.org> has canceled Gavin Peters
<gavinp at chromium.org>'s request for review:
Bug 52581: preventDefault() in beforeload should prevent request
https://bugs.webkit.org/show_bug.cgi?id=52581

Attachment 79893: Patch
https://bugs.webkit.org/attachment.cgi?id=79893&action=review

------- Additional Comments from Gavin Peters <gavinp at chromium.org>
I had some time on a flight today, and hammered out this test.	Unfortunately,
it fails right now; as you can see if you run it, the request for the IMG is
launched no matter what.

I poked at fixing it a bit, and there's something about how early the
ImageLoader is consed up is our source of trouble: the capture isn't
established the first time that ImageLoader::updateFromElement is called.


More information about the webkit-reviews mailing list