[webkit-reviews] review granted: [Bug 52934] Use WTF::StringHasher in WebCore : [Attachment 79873] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 23 16:23:15 PST 2011


Darin Adler <darin at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 52934: Use WTF::StringHasher in WebCore
https://bugs.webkit.org/show_bug.cgi?id=52934

Attachment 79873: Patch
https://bugs.webkit.org/attachment.cgi?id=79873&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=79873&action=review

> Source/JavaScriptCore/wtf/StringHasher.h:146
> +	   ASSERT(!(size % 2));

This is OK, but we could also use sizeof(UChar) here instead of the constant 2.


More information about the webkit-reviews mailing list