[webkit-reviews] review granted: [Bug 49618] Move CharacterNames.h into WTF directory : [Attachment 74219] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 49618: Move CharacterNames.h into WTF directory
https://bugs.webkit.org/show_bug.cgi?id=49618

Attachment 74219: Patch
https://bugs.webkit.org/attachment.cgi?id=74219&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74219&action=review

r=me

I'll be the tie-breaker.  It's just a header full of constants, so it's easy
enough to move back to WebCore if there is a compelling reason to do so.  I
like the idea of preventing code duplication, even if it's only 1 character
constant.  And it seems to fit in with JavaScriptCore/wtf/unicode just as well
as WebCore/platform/text (if not a little more so).

>> JavaScriptCore/wtf/unicode/CharacterNames.h:112
>> +using WTF::Unicode::zeroWidthSpace;
> 
> Can't you just use this instead?
> 
> using WTF::Unicode;

Per @ap, you don't want to do this because that will make every method and
constant in WTF::Unicode available without specifying a namespace, so this code
is fine as-is.