[webkit-reviews] review granted: [Bug 52971] ASSERT running run-webkit-tests --threaded : [Attachment 79862] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 22 20:54:30 PST 2011


mitz at webkit.org has granted Geoffrey Garen <ggaren at apple.com>'s request for
review:
Bug 52971: ASSERT running run-webkit-tests --threaded
https://bugs.webkit.org/show_bug.cgi?id=52971

Attachment 79862: Patch
https://bugs.webkit.org/attachment.cgi?id=79862&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=79862&action=review

> Source/JavaScriptCore/runtime/ConservativeSet.h:46
> +    static const size_t inlineCapacity = 128;

The increased inline capacity might be worth mentioning in the change log.

> Source/JavaScriptCore/runtime/ConservativeSet.h:70
> +    if (m_set == m_inlineSet)
> +	   return;
> +    OSAllocator::decommitAndRelease(m_set, m_capacity * sizeof(JSCell*));

I know how to turn this into a 2-line function.


More information about the webkit-reviews mailing list