[webkit-reviews] review granted: [Bug 52956] [Qt] Support layoutTestController.addURLToRedirect() : [Attachment 79842] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 52956: [Qt] Support layoutTestController.addURLToRedirect()
https://bugs.webkit.org/show_bug.cgi?id=52956

Attachment 79842: Patch
https://bugs.webkit.org/attachment.cgi?id=79842&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79842&action=review

r=me, one comment.

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:1027
> +    QString url = newRequest.url().string();
> +    if (URLsToRedirect.contains(url))
> +	   newRequest.setURL(QUrl(URLsToRedirect[url]));

Let's only do this if QWebPagePrivate::drtRun is true.