[webkit-reviews] review denied: [Bug 52945] crash @ WebCore::ResourceLoader::didCancel(WebCore::ResourceError const &) : [Attachment 79822] defensive checks for m_documentLoader being NULL

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied raman tenneti
<rtenneti at chromium.org>'s request for review:
Bug 52945: crash @ WebCore::ResourceLoader::didCancel(WebCore::ResourceError
const &)
https://bugs.webkit.org/show_bug.cgi?id=52945

Attachment 79822: defensive checks for m_documentLoader being NULL
https://bugs.webkit.org/attachment.cgi?id=79822&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r- for lack of tests and for tabs.

This looks very much like some bug I investigated recently, so I'd like to
think about this in depth. Generally, early returns on null checks should be
added very cautiously, because it's hard to tell which class invariants get
violated by not running the remainder of the function, and you end up
investigating much more mysterious bugs a few months later.

Thanks for posting a lot of detail about your investigation, it's really
helpful.