[webkit-reviews] review requested: [Bug 52945] crash @ WebCore::ResourceLoader::didCancel(WebCore::ResourceError const &) : [Attachment 79822] defensive checks for m_documentLoader being NULL

[bugzilla-daemon at webkit.org]

raman tenneti <rtenneti at chromium.org> has asked  for review:
Bug 52945: crash @ WebCore::ResourceLoader::didCancel(WebCore::ResourceError
const &)
https://bugs.webkit.org/show_bug.cgi?id=52945

Attachment 79822: defensive checks for m_documentLoader being NULL
https://bugs.webkit.org/attachment.cgi?id=79822&action=review

------- Additional Comments from raman tenneti <rtenneti at chromium.org>
in FrameLoader.cpp, we check for m_documentLoader before accessing it. Because
the code is reentrant, releaseResources could have been called and
m_documentLoader is set to 0.

This is a hard bug to duplicate. I was able to duplicate it with the chrome
build by cancelling the Print dialog. Wasn't able to reproduce it after adding
these checks.

thanks,
raman