[webkit-reviews] review granted: [Bug 52891] [Qt] Move project files into Source : [Attachment 79745] proposed patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 52891: [Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

Attachment 79745: proposed patch
https://bugs.webkit.org/attachment.cgi?id=79745&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79745&action=review

Great work! r=me with some minor reflections. Please fix 
them and make a force clean build on our buildbots when you.

( Just a good advice: Next time use git diff -M if you rename
or move files. It will make the patch more easily reviewable. )

Fix run-javascriptore-tests (webkitdirs.pm in sub jscProductDir):
-    $productDir .= "/Source/JavaScriptCore" if isQt();
+    $productDir .= "/JavaScriptCore" if isQt();

> Source/WebKit2/DerivedSources.pro:44
> -SRC_ROOT_DIR = $$replace(PWD, /Source/WebKit2, /)
> +SRC_ROOT_DIR = $$replace(PWD, /Source/WebKit2, "")

> Source/WebKit2/DerivedSources.pro:114
> -message_header_generator.commands = $${PYTHON}
$${SRC_ROOT_DIR}Source/WebKit2/Scripts/generate-messages-header.py
${QMAKE_FILE_IN} > ${QMAKE_FILE_OUT}
> +message_header_generator.commands = $${PYTHON}
$${SRC_ROOT_DIR}/Source/WebKit2/Scripts/generate-messages-header.py
${QMAKE_FILE_IN} > ${QMAKE_FILE_OUT}
...

Nice catch. ;)

> Tools/Scripts/webkitdirs.pm:1591
> +    # FIXME Iterate over different source directories manually to workaround
a problem with qmake+extraTargets+s60

s/FIXME/FIXME: