[webkit-reviews] review granted: [Bug 52910] Add various clampToInt() methods to MathExtras.h : [Attachment 79774] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 52910: Add various clampToInt() methods to MathExtras.h
https://bugs.webkit.org/show_bug.cgi?id=52910

Attachment 79774: Patch
https://bugs.webkit.org/attachment.cgi?id=79774&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
r+,
but have you thought about how these methods will handle NaN? - I'm guessing
that the answer is, we don't care for CSS - in which case I'd suggest
ASSERT(!isNaN(d)) in each.  If you're not going to guard against NaN, I think
you should document what expected behaviour is.