[webkit-reviews] review denied: [Bug 52467] REGRESSION (r72119): Audio never plays on Star Wars intro animation : [Attachment 79765] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied  review:
Bug 52467: REGRESSION (r72119): Audio never plays on Star Wars intro animation
https://bugs.webkit.org/show_bug.cgi?id=52467

Attachment 79765: Patch
https://bugs.webkit.org/attachment.cgi?id=79765&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=79765&action=review

Clearing r+ flag for now, this needs some more work.

> Source/WebCore/platform/graphics/win/QTMovie.cpp:-813
> -		   // Only add "audio/..." and "video/..." types.
> -		   if (strncmp(typeBuffer, "audio/", 6) && strncmp(typeBuffer,
"video/", 6))
> -		       continue;

This filtering is important, QuickTime can open *lots* of MIME types we don't
want the media element to support.

> Source/WebCore/platform/graphics/win/QTMovie.cpp:-831
> -		   // Only add each type once.
> -		   bool alreadyAdded = false;
> -		   for (int addedIndex = 0; addedIndex <
gSupportedTypes->size(); addedIndex++) {
> -		       CFStringRef type = gSupportedTypes->at(addedIndex);
> -		       if (kCFCompareEqualTo == CFStringCompare(cfMimeType,
type, kCFCompareCaseInsensitive)) {
> -			   alreadyAdded = true;
> -			   break;
> -		       }
> -		   }
> -		   if (!alreadyAdded)
> -		       gSupportedTypes->append(cfMimeType);
> -		   else
> -		       CFRelease(cfMimeType);

The new code should only add each type to the array once.