[webkit-reviews] review granted: [Bug 52911] [v8] Refactoring: extract IntrusiveDOMWrapperMap into a seprate class and files. : [Attachment 79773] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 21 12:27:26 PST 2011


Nate Chapin <japhet at chromium.org> has granted anton muhin
<antonm at chromium.org>'s request for review:
Bug 52911: [v8] Refactoring: extract IntrusiveDOMWrapperMap into a seprate
class and files.
https://bugs.webkit.org/show_bug.cgi?id=52911

Attachment 79773: Patch
https://bugs.webkit.org/attachment.cgi?id=79773&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79773&action=review

I'd be inclined to just go ahead and fix the namespace indent.	Start this file
off confirming to style guide and all that :)

> Source/WebCore/bindings/v8/IntrusiveDOMWrapperMap.cpp:36
> +bool IntrusiveDOMWrapperMap::removeIfPresent(Node* obj,
v8::Persistent<v8::Object> value)

Is there something special about this function that it's the only one
implemented in the cpp?  Just seems a weird split between the .h and the .cpp
to me.


More information about the webkit-reviews mailing list