[webkit-reviews] review granted: [Bug 52904] PlatformCAAnimationWin is leaky and inefficient : [Attachment 79752] Clean up PlatformCAAnimationWin

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 21 10:02:49 PST 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 52904: PlatformCAAnimationWin is leaky and inefficient
https://bugs.webkit.org/show_bug.cgi?id=52904

Attachment 79752: Clean up PlatformCAAnimationWin
https://bugs.webkit.org/attachment.cgi?id=79752&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=79752&action=review

> Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.cpp:125
> -static CACFTimingFunctionRef toCACFTimingFunction(const TimingFunction*
timingFunction)
> +static RetainPtr<CACFTimingFunctionRef> toCACFTimingFunction(const
TimingFunction* timingFunction)

Do we use the create moniker for things that return RetainPtrs?


More information about the webkit-reviews mailing list