[webkit-reviews] review requested: [Bug 51456] Introduce FontMetrics abstraction : [Attachment 79730] Patch v11

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 51456: Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456

Attachment 79730: Patch v11
https://bugs.webkit.org/attachment.cgi?id=79730&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Updated patch v11 to trunk. Save memory in FontMetrics by not storing but
computing the lineSpacing() from the lineGap / ascent / descent, remaining
compatibility with existing DRT expectations.
Current assumption across most ports (mac/win/chromium/gtk...) is "lineSpacing
= lroundf(ascent) + lroundf(descent) + lroundf(lineGap)". In my previous patch
I stored m_lineSpacing as "lineSpacing = lroundf(floatAscent + floatDescent +
floatLineGap)" which lead to several changes in layout tests, which might be
correct, but I don't want to cause any layout test changes with this patch.