[webkit-reviews] review requested: [Bug 52422] [chromium] More crash in FontFallbackList::determinePitch(const Font* font) : [Attachment 79721] A speculative fix 2

[bugzilla-daemon at webkit.org]

Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 52422: [chromium] More crash in FontFallbackList::determinePitch(const
Font* font)
https://bugs.webkit.org/show_bug.cgi?id=52422

Attachment 79721: A speculative fix 2
https://bugs.webkit.org/attachment.cgi?id=79721&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
(In reply to comment #4)
> Tamura-san has reported a case that causes this crash while integrating
vertical-text support to Chromium at Bug 51450: <http://webkit.org/b/51450>. I
will investigate his case and update the change.

To investigate the above case, I noticed FontCache::createFontPlatformData() of
Chromium might return 0 when users changed the system fonts to a font which has
localized names on Windows XP, such as "HGGothicM". When a font has localized
names, localized Windows returns its localized name for GetObject() call. That
is, when we create a font with its English name ("HGGothicM"), the returned
font name becomes its localized name "HGゴシックM". This caused a font-name
mismatch in FontCache::createFontPlatformData() and this function returns 0
when my previous fix gets system fonts for a last-resort font. I have updated
my change so we can bypass the said font-name check when finding the
last-resort font. It would be definitely helpful to give me feedbacks.

Regards,

Hironori Bono