[webkit-reviews] review granted: [Bug 51155] [GTK] Menulist text often collides with separator : [Attachment 79610] Patch fixing paintRect issue

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 51155: [GTK] Menulist text often collides with separator
https://bugs.webkit.org/show_bug.cgi?id=51155

Attachment 79610: Patch fixing paintRect issue
https://bugs.webkit.org/attachment.cgi?id=79610&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=79610&action=review

Looks reasonable to me. r=me

> Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:335
> +    static GtkBorder defaultInnerBorder = {1, 1, 1, 1};

Hrm, is making this static useful/needed? It could be const, on the other hand.


> Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:365
> +	   getComboBoxSeparatorWidth() + (3 * buttonWidgetStyle->xthickness);

Hrm, so where does the 3 come from?

> Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:408
> +    // | left border | Button text | xthickness | vseparator | xthickness |
arrow | xthickness | right border |

Oh, I guess the 3 comes from here.