[webkit-reviews] review granted: [Bug 52852] Syncing compositing state and rendering are intertwined in WKCACFLayerRenderer, but shouldn't be : [Attachment 79664] Separate compositing state syncing from rendering in WKCACFLayerRenderer

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 52852: Syncing compositing state and rendering are intertwined in
WKCACFLayerRenderer, but shouldn't be
https://bugs.webkit.org/show_bug.cgi?id=52852

Attachment 79664: Separate compositing state syncing from rendering in
WKCACFLayerRenderer
https://bugs.webkit.org/attachment.cgi?id=79664&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=79664&action=review

> Source/WebCore/platform/graphics/ca/win/CompositingStateSyncer.cpp:92
> +    m_isCallingRenderers = true;
> +    for (size_t i = 0; i < renderers.size(); ++i)
> +	   renderers[i]->syncCompositingStateNowIfNeeded();
> +    m_isCallingRenderers = false;

The name m_isCallingRenderers is a bit vague (and easily confused with Render
objects).

> Source/WebCore/platform/graphics/ca/win/CompositingStateSyncer.h:39
> +class CompositingStateSyncer {

I'm not a big fan of this name. I started to use "flush pending layer changes"
nomenclature in RenderLayerCompositor (we're not really synchronizing anything
here).