[webkit-reviews] review granted: [Bug 52855] WebKit2: Implement showModalDialog : [Attachment 79683] Patch addressing Mitz’s comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 20 19:29:29 PST 2011


mitz at webkit.org has granted Darin Adler <darin at apple.com>'s request for review:
Bug 52855: WebKit2: Implement showModalDialog
https://bugs.webkit.org/show_bug.cgi?id=52855

Attachment 79683: Patch addressing Mitz’s comments
https://bugs.webkit.org/attachment.cgi?id=79683&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=79683&action=review

> Source/WebKit2/UIProcess/API/C/WKPage.h:173
> -    const void *							  
clientInfo;
> +    const void*							  
clientInfo;

This change is inconsistent with other client interfaces in WebKit2.


More information about the webkit-reviews mailing list