[webkit-reviews] review granted: [Bug 52645] REGRESSION: Multi-second hangs in ImageQualityController::objectDestroyed() : [Attachment 79639] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 52645: REGRESSION: Multi-second hangs in
ImageQualityController::objectDestroyed()
https://bugs.webkit.org/show_bug.cgi?id=52645

Attachment 79639: Patch
https://bugs.webkit.org/attachment.cgi?id=79639&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=79639&action=review

It’s not good that objectDestroyed shows up on the profile for the iBench HTML
test at all, but this is much better than before.

> Source/WebCore/ChangeLog:16
> +	   Fix performance regression in
ImageQualityController::objectDestroyed().
> +	   https://bugs.webkit.org/show_bug.cgi?id=52645
> +
> +	   * rendering/RenderBoxModelObject.cpp:
> +	   (WebCore::ImageQualityController::isEmpty):
> +	   (WebCore::ImageQualityController::removeLayer):
> +	   (WebCore::ImageQualityController::set):
> +	   (WebCore::ImageQualityController::objectDestroyed):
> +	   (WebCore::ImageQualityController::highQualityRepaintTimerFired):
> +	   (WebCore::ImageQualityController::shouldPaintAtLowQuality):
> +	   (WebCore::imageQualityController):
> +	   (WebCore::RenderBoxModelObject::~RenderBoxModelObject):

This is not a great change log entry. It doesn’t explain why this is a good
change or even say what the change is.