[webkit-reviews] review granted: [Bug 52837] [v8] CodeGeneratorV8 generates incorrect code for callbacks with no parameters : [Attachment 79643] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 20 13:31:06 PST 2011


Nate Chapin <japhet at chromium.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 52837: [v8] CodeGeneratorV8 generates incorrect code for callbacks with no
parameters
https://bugs.webkit.org/show_bug.cgi?id=52837

Attachment 79643: Patch
https://bugs.webkit.org/attachment.cgi?id=79643&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79643&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2406
> +	       } else {
> +		   push(@implContent, "\n    v8::Handle<v8::Value> *argv =
0;\n\n");
> +	       }

Nit: no {} for the else statement


More information about the webkit-reviews mailing list