[webkit-reviews] review granted: [Bug 51678] Support for OES_standard_derivatives : [Attachment 79541] Implementation of OES_standard_derivatives

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 20 12:38:43 PST 2011


Kenneth Russell <kbr at google.com> has granted Ben Vanik <ben.vanik at gmail.com>'s
request for review:
Bug 51678: Support for OES_standard_derivatives
https://bugs.webkit.org/show_bug.cgi?id=51678

Attachment 79541: Implementation of OES_standard_derivatives
https://bugs.webkit.org/attachment.cgi?id=79541&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
This looks perfect. Thanks for implementing it. The only questionable part is
making Extensions3DOpenGL a friend of GraphicsContext3D on the Mac, but I
actually think that's cleaner than providing an accessor method for the
ANGLEWebKitBridge, which is a class we have been thinking about throwing out
entirely.


More information about the webkit-reviews mailing list