[webkit-reviews] review granted: [Bug 52822] [Qt] Clean up the Media Controls CSS for Qt : [Attachment 79616] first try

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 20 11:00:18 PST 2011


Eric Carlson <eric.carlson at apple.com> has granted yi shen
<yi.4.shen at nokia.com>'s request for review:
Bug 52822: [Qt] Clean up the Media Controls CSS for Qt
https://bugs.webkit.org/show_bug.cgi?id=52822

Attachment 79616: first try
https://bugs.webkit.org/attachment.cgi?id=79616&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=79616&action=review

Marking r+ but cq- as it doesn't look like this is quite right (or I am not
looking at it correctly ;-) )

> Source/WebCore/css/mediaControlsQtFullscreen.css:62
> +video::-webkit-media-controls-time-remaining-display {
>      display: none;
>  }

Does this change anything?

> Source/WebCore/css/mediaControlsQtFullscreen.css:80
> +video::-webkit-media-controls-seek-back-button {
>      display: none;
>  }

Or this?

> Source/WebCore/css/mediaControlsQtFullscreen.css:84
> +video::-webkit-media-controls-seek-forward-button {
>      display: none;
>  }

Ditto.

> Source/WebCore/css/mediaControlsQtFullscreen.css:92
> +video::-webkit-media-controls-rewind-button {
>      display: none;
>  }

Ditto.

> Source/WebCore/css/mediaControlsQtFullscreen.css:96
> +video::-webkit-media-controls-return-to-realtime-button {
>      display: none;
>  }

Ditto.

> Source/WebCore/css/mediaControlsQtFullscreen.css:100
> +video::-webkit-media-controls-toggle-closed-captions-button {
>      display: none;
>  }

Ditto.


More information about the webkit-reviews mailing list