[webkit-reviews] review requested: [Bug 51128] [Symbian] OSAllocator implementation : [Attachment 79609] Symbian implementation for OSAllocator

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 20 09:09:12 PST 2011


Siddharth Mathur <siddharth.mathur at nokia.com> has asked  for review:
Bug 51128: [Symbian] OSAllocator implementation
https://bugs.webkit.org/show_bug.cgi?id=51128

Attachment 79609: Symbian implementation for OSAllocator
https://bugs.webkit.org/attachment.cgi?id=79609&action=review

------- Additional Comments from Siddharth Mathur <siddharth.mathur at nokia.com>
Some notes about the patch: 
- Most of the meat is in OSAllocatorSymbian.cpp
- Unlike Unix and Windows, we need context (in the form of an RChunk object) to
do reserve() and commit(). Therefore, given the static nature of interfaces in
OSAllocator.h and its consumer classes, I have used static variables for the
chunk handles. 
- Based on the Usage enum and on the bytes requested, the commit or reserve
request is routed to the appropriate backing chunk (via getBackingChunk()
helper), or to the process' malloc/User::Alloc implementation (regular heap
allocator) 
- I have tested that V8 benchmark test (version 5) runs to completion using
QtTestBrowser on an N8 device.


More information about the webkit-reviews mailing list