[webkit-reviews] review canceled: [Bug 51155] [GTK] Menulist text often collides with separator : [Attachment 79323] Patch rebased against the latest

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has canceled Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 51155: [GTK] Menulist text often collides with separator
https://bugs.webkit.org/show_bug.cgi?id=51155

Attachment 79323: Patch rebased against the latest
https://bugs.webkit.org/attachment.cgi?id=79323&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79323&action=review

>> Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:411
>> +
> 
> hmm I didn't know that style property, we are not checking it, so I guess we
are assuming that if the combobox widget doesn't have a separator in its
children widget list it's because appears-as-list = 1

Yep. We have to have the child widgets anyway, to ensure proper rendering, so
we just check there. This was inspired by the Mozilla code.

>> Source/WebCore/platform/gtk/WidgetRenderingContext.cpp:208
>> +			static_cast<GtkArrowType>(arrowDirection), TRUE,
paintRect.x, paintRect.y, paintRect.width, paintRect.height);
> 
> You are using m_paintRect here instead of paintRect

Very right. I had fixed this locally, but I should upload a new patch.