[webkit-reviews] review canceled: [Bug 51984] [WK2][Qt] Multiple problems with MemoryMappedPool : [Attachment 79274] First try removing Cleanup Handler

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 20 08:53:10 PST 2011


Kimmo Kinnunen <kimmo.t.kinnunen at nokia.com> has canceled Kimmo Kinnunen
<kimmo.t.kinnunen at nokia.com>'s request for review:
Bug 51984: [WK2][Qt] Multiple problems with MemoryMappedPool
https://bugs.webkit.org/show_bug.cgi?id=51984

Attachment 79274: First try removing Cleanup Handler
https://bugs.webkit.org/attachment.cgi?id=79274&action=review

------- Additional Comments from Kimmo Kinnunen <kimmo.t.kinnunen at nokia.com>
The performance regression was due to leaking fd handles that were passed to
the other process. This caused them to be synced to the disk and thus
performance regression.

This also implements Connection::connectionDidClose. This is needed when web
process crashes. The detection is implemented by observing the web process
termination. To test this, bug 52796 is needed.


More information about the webkit-reviews mailing list