[webkit-reviews] review denied: [Bug 26584] [Qt] Provide a way for better control over the process of printing : [Attachment 79593] Patch to try do turn this bug alive again

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin.poulain at nokia.com> has denied Diego Gonzalez
<diegohcg at webkit.org>'s request for review:
Bug 26584: [Qt] Provide a way for better control over the process of printing
https://bugs.webkit.org/show_bug.cgi?id=26584

Attachment 79593: Patch to try do turn this bug alive again
https://bugs.webkit.org/attachment.cgi?id=79593&action=review

------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
(In reply to comment #32)
> Created an attachment (id=79593) [details]
> Patch to try do turn this bug alive again

It is nice someone is working on this.

But I do not get the purpose of your patch(?). The QWebPrinter is not
accessible by the public API. The test is also not really testing anything new
there.

The changelog do not describe anything so not much help there.


Personnally, I would like to see the printing support improve. I thing a public
class to control the print settings could make sense. If this is done, I think
that should not be for just one use case but for the most common settings
offered by QtWebKit.

Since it is new API, it will need API review. You can start a new thread on the
mailing list to suggest a new API. This way the chance of changes because of
the API review is lower.