[webkit-reviews] review denied: [Bug 51871] [Qt][WK2] QWKContext should offer the available process models : [Attachment 78924] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 51871: [Qt][WK2] QWKContext should offer the available process models
https://bugs.webkit.org/show_bug.cgi?id=51871

Attachment 78924: Patch
https://bugs.webkit.org/attachment.cgi?id=78924&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78924&action=review

> Tools/MiniBrowser/qt/BrowserView.cpp:36
> -    , m_context(context ? context : new QWKContext(this))
> +    , m_context(context ? context : new QWKContext(this,
QWKContext::SharedProcess))

I think we should test the shared context mode a lot more before making it the
default.
The rest of this patch is fine, but you should add something like a CLI option
to MiniBrowser to choose the mode.