[webkit-reviews] review denied: [Bug 52791] Buffer overrun in WebCore::InspectorBasicValue::writeJSON : [Attachment 79562] Patch with fix for InspectorBasicValue::writeJSON

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Mikołaj Małecki
<m.malecki at samsung.com>'s request for review:
Bug 52791: Buffer overrun in WebCore::InspectorBasicValue::writeJSON
https://bugs.webkit.org/show_bug.cgi?id=52791

Attachment 79562: Patch with fix for InspectorBasicValue::writeJSON
https://bugs.webkit.org/attachment.cgi?id=79562&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79562&action=review

Thanks for the patch!  However every change requires a test and a ChangeLog.

> WebCore/inspector/InspectorValues.cpp:610
> +	   DecimalNumber dv = m_doubleValue;

See the webkit style guide about variable naming.

> WebCore/inspector/InspectorValues.cpp:613
> +	       // there is NOT ENOUGH ROOM, sorry. Use exponential format.

Comments should be sentences, beginning with a capital and ending with a
period.

> WebCore/inspector/InspectorValues.cpp:615
> +		   // Not even for this one? Sorry, you WON'T have a number.

I'm not sure this is a very useful comment.