[webkit-reviews] review granted: [Bug 52557] <keygen> presents itself as a HTMLSelectElement to script : [Attachment 79387] Syncs to head and makes GTK build.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 19 22:06:43 PST 2011


Kent Tamura <tkent at chromium.org> has granted  review:
Bug 52557: <keygen> presents itself as a HTMLSelectElement to script
https://bugs.webkit.org/show_bug.cgi?id=52557

Attachment 79387: Syncs to head and makes GTK build.
https://bugs.webkit.org/attachment.cgi?id=79387&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79387&action=review

> Source/WebCore/ChangeLog:13
> +	   Make <keygen> no longer appear to be a <select> element to script.
> +
> +	   The intent is to put <keygen> options into shadow DOM. This change
> +	   takes the first step by hiding the <select> element from
> +	   JavaScript.
> +
> +	   Test: fast/dom/HTMLKeygenElement/keygen.html
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=52557

nit: We usually use the following format:

    <summary>
    <bug URL>

    <description>

    Test: <test names>


More information about the webkit-reviews mailing list