[webkit-reviews] review denied: [Bug 52733] [Qt] Fix Layering violation in MediaPlayerPrivateQt... : [Attachment 79532] proposed patch II...

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Dawit A.
<adawit at kde.org>'s request for review:
Bug 52733: [Qt] Fix Layering violation in MediaPlayerPrivateQt...
https://bugs.webkit.org/show_bug.cgi?id=52733

Attachment 79532: proposed patch II...
https://bugs.webkit.org/attachment.cgi?id=79532&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=79532&action=review

r- as the ChangeLog needs to be fixed.

> Source/WebCore/ChangeLog:5
> +	   [Qt] Fix Layering violation in MediaPlayerPrivateQt...

One dot please.

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

OOPS would need to go - from http://webkit.org/coding/contributing.html

The "No new tests. (OOPS!)" line appears if prepare-ChangeLog did not detect
the addition of test cases. If your patch does not require test cases (or test
cases are not possible), you should include a line stating such. Otherwise all
changes require test cases which should be mentioned in the ChangeLog.