[webkit-reviews] review requested: [Bug 51678] Support for OES_standard_derivatives : [Attachment 79541] Implementation of OES_standard_derivatives

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 19 19:12:00 PST 2011


Ben Vanik <ben.vanik at gmail.com> has asked  for review:
Bug 51678: Support for OES_standard_derivatives
https://bugs.webkit.org/show_bug.cgi?id=51678

Attachment 79541: Implementation of OES_standard_derivatives
https://bugs.webkit.org/attachment.cgi?id=79541&action=review

------- Additional Comments from Ben Vanik <ben.vanik at gmail.com>
Implementation of the OES_standard_derivatives WebGL extension.

Changes are modeled off of the existing OESTextureFloat extension. New files,
extension retrieval, etc all match the existing code.

Changed ANGLEWebKitBridge to allow for multiple sets of the ANGLE shader
compiler options. This supports the enabling of the standard derivatives flag
when the extension is enabled. Refactored the cleanup code to make the
destruction of the compilers (if they had been created) cleaner.

Tested with the WebGL conformance test:
https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conform
ance/oes-standard-derivatives.html
Passes on WebKit/OSX, Chromium/OSX, and Chromium/Windows.


More information about the webkit-reviews mailing list