[webkit-reviews] review denied: [Bug 52747] [reviewtool] Add a link for annotated trac page on review page : [Attachment 79524] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 19 18:41:41 PST 2011
Adam Barth <abarth at webkit.org> has denied Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 52747: [reviewtool] Add a link for annotated trac page on review page
https://bugs.webkit.org/show_bug.cgi?id=52747
Attachment 79524: Patch
https://bugs.webkit.org/attachment.cgi?id=79524&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79524&action=review
Screenshot? :)
> Websites/bugs.webkit.org/code-review.js:346
> + function tracLinksHtml(file_name, url_hash) {
> + return '<a href="http://trac.webkit.org/browser/trunk/' + file_name +
'?annotate=blame' + url_hash + '" target="_blank">annotate</a>' +
> + '<a href="http://trac.webkit.org/log/trunk/' + file_name + '"
target="_blank">revision log</a>';
> + }
You haz the XSS. file_name isn't trusted! Please use the DOM to construct
these links.
More information about the webkit-reviews
mailing list