[webkit-reviews] review granted: [Bug 52769] Crash in DOMWindow::setLocation() due to null m_frame : [Attachment 79525] patch + test

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 52769: Crash in DOMWindow::setLocation() due to null m_frame
https://bugs.webkit.org/show_bug.cgi?id=52769

Attachment 79525: patch + test
https://bugs.webkit.org/attachment.cgi?id=79525&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79525&action=review

I don't love the test.	Too many timeouts.  This test takes 1 whole second to
run!  There's got to be a better way.  For example, you can have the newly
opened window postMessage back to the original page to know that it's time to
close it.

> LayoutTests/fast/dom/Window/Location/set-location-after-close.html:14
> +setTimeout('w.location = \'\'; if (window.layoutTestController)
layoutTestController.notifyDone()', 1000);

\'\' -> ""