[webkit-reviews] review granted: [Bug 52627] Accelerated canvas2D has bad clipping performance : [Attachment 79303] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 52627: Accelerated canvas2D has bad clipping performance
https://bugs.webkit.org/show_bug.cgi?id=52627

Attachment 79303: Patch
https://bugs.webkit.org/attachment.cgi?id=79303&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79303&action=review

R=me

> Source/WebCore/platform/graphics/chromium/GLES2Canvas.cpp:289
> +	       for (pathIter = clippingPaths.begin();
> +		    pathIter < clippingPaths.end();
> +		    ++pathIter) {

nit: why wrap this line at all?

> Source/WebCore/platform/graphics/chromium/GLES2Canvas.cpp:317
> +void GLES2Canvas::drawTexturedRect(Texture* texture, const FloatRect&
srcRect, const FloatRect& dstRect, const AffineTransform& transform, float
alpha, ColorSpace colorSpace, CompositeOperator compositeOp, bool clip)

nit: file a bug, or better yet just change this to an enum now