[webkit-reviews] review granted: [Bug 48459] Glyphs in vertical text tests are rotated 90 degrees clockwise on Windows : [Attachment 77702] A patch to make WebKit Windows render vertical text correctly

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted  review:
Bug 48459: Glyphs in vertical text tests are rotated 90 degrees clockwise on
Windows
https://bugs.webkit.org/show_bug.cgi?id=48459

Attachment 77702: A patch to make WebKit Windows render vertical text correctly
https://bugs.webkit.org/attachment.cgi?id=77702&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I guess I will tentatively r+ this, although I'm not sure what behavior you get
with the @ added.  By not setting the orientation in SimpleFontData, you will
end up with that code thinking the font doesn't support vertical, but if the
built-in rendering just "does the right thing" then maybe that's ok.  I suspect
it won't be sufficient though, especially when we get around to supporting
text-orientation.  Still, if this gets the basics working then that seems
pretty good.