[webkit-reviews] review denied: [Bug 52622] Cache function offsets to speed up javascript parsing : [Attachment 79410] use shrinkToFit

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 52622: Cache function offsets to speed up javascript parsing
https://bugs.webkit.org/show_bug.cgi?id=52622

Attachment 79410: use shrinkToFit
https://bugs.webkit.org/attachment.cgi?id=79410&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=79410&action=review

r- due to comments

> Source/JavaScriptCore/parser/Lexer.h:88
> +	       ASSERT(token.m_type == CLOSEBRACE);
> +	       m_lineNumber = token.m_info.line;
> +	       setOffset(token.m_info.endOffset);
> +	       if (UNLIKELY(m_code == m_codeEnd))
> +		   m_current = -1;
> +	       m_delimited = true;
> +	       m_lastToken = CLOSEBRACE;

this should be a call to setOffset, although you'll need to transfer 
if (UNLIKELY(m_code == m_codeEnd))
     m_current = -1;

To setOffset as well.

> Source/JavaScriptCore/parser/SourceProvider.h:76
> +

I think we really want SourceProviderCache to hang off of SourceProvider
itself.  It will allow it to be devirtualised sensibly.