[webkit-reviews] review denied: [Bug 52723] Web Inspector: extract presentation code from debugger model : [Attachment 79427] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 19 11:29:56 PST 2011


Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 52723: Web Inspector: extract presentation code from debugger model
https://bugs.webkit.org/show_bug.cgi?id=52723

Attachment 79427: Patch.
https://bugs.webkit.org/attachment.cgi?id=79427&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79427&action=review

This does not look like "move" - too much new code. Could you split this change
into refactoring + new code?

> Source/WebCore/ChangeLog:5
> +	   Move breakpoints-related presentation code from debugger model to
JavaScriptBreakpointSidebarPane.

Web Inspector prefix please.


More information about the webkit-reviews mailing list