[webkit-reviews] review granted: [Bug 52258] [GTK] Move toggle button rendering out of gtk2drawing.c : [Attachment 79435] Patch fixing focus rect issue

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 52258: [GTK] Move toggle button rendering out of gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=52258

Attachment 79435: Patch fixing focus rect issue
https://bugs.webkit.org/attachment.cgi?id=79435&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79435&action=review

Except for these spelling nits I see no issues with this patch, so r=me!

> Source/WebCore/ChangeLog:11
> +	   (WebCore::adjustRectForFocus): Added this function which inflate a
rect based

inflates

> Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:189
> +    // We do not call gtk_toggle_button_set_active here, because begin a
series of animation

because begin? Are the series of animation timeouts started by
gtk_toggle_button_set_active?