[webkit-reviews] review denied: [Bug 52691] new-run-webkit-tests: remove use of os.walk, use mock filesystem for better unit testing : [Attachment 79375] revise approach to files_under() so we can handle reftests properly

[bugzilla-daemon at webkit.org]

Mihai Parparita <mihaip at chromium.org> has denied Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 52691: new-run-webkit-tests: remove use of os.walk, use mock filesystem for
better unit testing
https://bugs.webkit.org/show_bug.cgi?id=52691

Attachment 79375: revise approach to files_under() so we can handle reftests
properly
https://bugs.webkit.org/attachment.cgi?id=79375&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79375&action=review

> Tools/Scripts/webkitpy/common/system/filesystem.py:76
> +	   dirs_to_skip = dirs_to_skip or []

You can use [] as the default argument value to the function, since you're not
modifying the list.

> Tools/Scripts/webkitpy/common/system/filesystem_mock.py:75
> +	   dirs_to_skip = dirs_to_skip or []

Same here.

> Tools/Scripts/webkitpy/common/system/filesystem_mock.py:100
> +		       continue

This "continue" will only apply to the loop over dirs_to_skip, but I think you
want to continue the iteration in the self.files loop.