[webkit-reviews] review granted: [Bug 52694] new-run-webkit-tests: add a --build-directory command line argument : [Attachment 79379] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 18 19:54:06 PST 2011


Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 52694: new-run-webkit-tests: add a --build-directory command line argument
https://bugs.webkit.org/show_bug.cgi?id=52694

Attachment 79379: Patch
https://bugs.webkit.org/attachment.cgi?id=79379&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79379&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:281
> +	   optparse.make_option("--build-directory",
> +	       help="Absolute path to the directory under which build files are
kept (should not include configuration)"),

Does it have to be absolute?  Won't paths relative to where NRWT is run from
work?


More information about the webkit-reviews mailing list