[webkit-reviews] review granted: [Bug 52608] Refactoring: EventHandler::handleTextInputEvent should accept an enum instead of three bools : [Attachment 79380] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 18 18:59:53 PST 2011


Ryosuke Niwa <rniwa at webkit.org> has granted  review:
Bug 52608: Refactoring: EventHandler::handleTextInputEvent should accept  an
enum instead of three bools
https://bugs.webkit.org/show_bug.cgi?id=52608

Attachment 79380: Patch
https://bugs.webkit.org/attachment.cgi?id=79380&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
(In reply to comment #4)
> Oops, we shouldn't be claiming to be the author if we're just moving it here.


I just realized you're the original author of this enum in
http://trac.webkit.org/changeset/65287. I put my r+ back.

Please still correct the location of TextEventInputType.h in
WebCore.xcodeproj/project.pbxproj as noted above.


More information about the webkit-reviews mailing list