[webkit-reviews] review granted: [Bug 52608] Refactoring: EventHandler::handleTextInputEvent should accept an enum instead of three bools : [Attachment 79380] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 52608: Refactoring: EventHandler::handleTextInputEvent should accept  an
enum instead of three bools
https://bugs.webkit.org/show_bug.cgi?id=52608

Attachment 79380: Patch
https://bugs.webkit.org/attachment.cgi?id=79380&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79380&action=review

> Source/WebCore/page/EventHandler.cpp:2670
> -    RefPtr<TextEvent> event = TextEvent::create(m_frame->domWindow(), text,
TextEvent::selectInputType(isLineBreak, isBackTab));
> +    RefPtr<TextEvent> event = TextEvent::create(m_frame->domWindow(), text,
inputType);

Only concern I have with this change is that we may permit inputType to be
TextEventInputPaste or TextEventInputDrop here. Can we add an assertion that
this can only be Keyboard, LineBreak, or BackTab?