[webkit-reviews] review granted: [Bug 52661] [chromium] simplify complex text code, fixing a handful of layout tests : [Attachment 79322] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Evan Martin <evan at chromium.org>'s
request for review:
Bug 52661: [chromium] simplify complex text code, fixing a handful of layout
tests
https://bugs.webkit.org/show_bug.cgi?id=52661

Attachment 79322: Patch
https://bugs.webkit.org/attachment.cgi?id=79322&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79322&action=review

> Source/WebCore/platform/graphics/chromium/FontLinux.cpp:212
> +	   // FIXME: this causes us to shape the text twice -- once to compute
the width and then again
> +	   // below when actually rendering.  Change ComplexTextController to
match platform/mac and
> +	   // platform/chromium/win by having it store the shaped runs, so we
can reuse the results.

This is my only concern with this patch but evan said he would (1) watch the
intl page cycler bots for regressions and (2) work on trying to clean this up
so we don't have to shave the text twice (perhaps by doing what Windows does).